Skip to content

Replace $ check for jQuery check #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2016
Merged

Replace $ check for jQuery check #328

merged 1 commit into from
Mar 14, 2016

Conversation

mdtusz
Copy link
Contributor

@mdtusz mdtusz commented Mar 14, 2016

Fixes #325.

This shouldn't cause any issues at all as $ === jQuery.

@etpinard
Copy link
Contributor

💃

@mdtusz
Copy link
Contributor Author

mdtusz commented Mar 14, 2016

Nothing like a nice easy Monday morning PR.

mdtusz added a commit that referenced this pull request Mar 14, 2016
@mdtusz
Merge pull request #328 from plotly/jquery-namespace
7882ba5 
Replace $ check for jQuery check
@mdtusz mdtusz merged commit 7882ba5 into master Mar 14, 2016
@etpinard etpinard deleted the jquery-namespace branch March 21, 2016 15:55
@timelyportfolio timelyportfolio mentioned this pull request Mar 22, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdtusz @etpinard